Closed
Bug 971970
Opened 11 years ago
Closed 7 years ago
clang-format all the APZ code
Categories
(Core :: Panning and Zooming, defect, P3)
Core
Panning and Zooming
Tracking
()
RESOLVED
DUPLICATE
of bug 1188202
People
(Reporter: kats, Unassigned)
References
Details
(Whiteboard: [gfx-noted])
Our code is hella-inconsistent with formatting. We should just clang-format it using the mozilla style rules on central.
|
Reporter | |
Comment 1•11 years ago
|
||
After running mach clang-format, there should be a clang-format-3.5 binary in the ~/.mozbuild/ folder. This can be used to format the code. I did this on the APZ code like so:
cd $MOZILLA/gfx/layers/apz
for i in $(find . -type f); do ~/.mozbuild/clang-format-3.5 -style=Mozilla -i $i; done
However the results were less than optimal, particularly with wrapping comment blocks (it just adds linebreaks instead of properly reflowing) so this will require some manual fixup.
|
|
Reporter | |
Updated•9 years ago
|
Whiteboard: [gfx-noted]
|
|
Reporter | |
Updated•9 years ago
|
OS: Gonk (Firefox OS) → All
|
||
Updated•7 years ago
|
Priority: -- → P3
|
|
Reporter | |
Comment 2•7 years ago
|
||
This is going to be done in bug 1188202, to the whole tree.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•